Return longest text after failing to detect text longer than the configured value #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreskrey
changed the title
|
@gijsk Ready! |
gijsk
approved these changes
Feb 27, 2018
Readability.js
Outdated
| }); | ||
|
|
||
| // But first check if we actually have something | ||
| if (this._attempts[0].textLength === 0) { |
There was a problem hiding this comment.
Can you make this just if (!this._attempts[0].textLength) ?
|
Done! |
gijsk
reviewed
Feb 27, 2018
Readability.js
Outdated
| @@ -1112,7 +1112,7 @@ Readability.prototype = { | |||
| }); | |||
|
|
|||
| // But first check if we actually have something | |||
| if (this._attempts[0].textLength === 0) { | |||
| if (this._attempts[0].textLength) { | |||
There was a problem hiding this comment.
You missed out the !, which unfortunately is quite important...
There was a problem hiding this comment.
(I would just fix this myself and land manually, but I'm afraid my github fu is really weak and I'm in the middle of something else right now)
|
Bah! that's what happens when you try to fix a review quickly before lunch :F |
andreskrey
deleted the
issue-381-try-to-return-text-after-all-attempts-failed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at #381. Original PR was #421.
WIP. Will notify once test case is done.